Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43959 )
Change subject: soc/mediatek/mt8192: Add gpio driver ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... File src/soc/mediatek/mt8192/gpio.c:
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 1: /* need SPDX header
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 60: enum Please align this with "gpio_t gpio".
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 85: enum Please align this with "gpio_t gpio".
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 116: Extra blank line.