Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )
Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... PS4, Line 57: CONFIG(SUPERIO_NUVOTON_NCT6779D_COM_A))
For the future, we could just have a single Kconfig, reflecting what it does, e.g. […]
good idea. i'm ok with doing that as a follow-up patch. from what i saw on the one different case it's the same bit that needs to be cleared and the issue was probably that not only that bit was cleared, but that the whole register was rewritten. might be worth looking into that; maybe we only need one Kconfig symbol for all Nuvoton SIO chips