Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42986 )
Change subject: mb/google/vilboz: Drop gpio.c from variants/vilboz
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42986/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42986/1//COMMIT_MSG@13
PS1, Line 13:
Can you please verify that this is correct as well: https://review.coreboot.org/cgit/coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/42986/6/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/gpio.c:
PS6:
In that case, VARIANT_MIN_BOARD_ID_V3_SCHEMATICS needs to be set as 1 for Vilboz and VARIANT_MIN_BOA […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f8b233b56185f3281ad7127bc274bda5ea801
Gerrit-Change-Number: 42986
Gerrit-PatchSet: 10
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jul 2020 04:43:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-MessageType: comment