Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 60:
(55 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/63c2f950_31c4ae5b PS60, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/6d7396af_7c44d5f5 PS60, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/56a5fc51_6b6d0086 PS60, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/48aab952_10d2ed3b PS60, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/3fb60f07_6f431238 PS60, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/fe3e3505_bd72527f PS60, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/a8e8e520_86ff19e5 PS60, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/982d6dee_da9b62da PS60, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/548d006f_c4a5c639 PS60, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/f9ffde00_01a218bf PS60, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/4ec52b04_953da3dd PS60, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/cbd39d12_987dbeb8 PS60, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/2092f742_7532ddd0 PS60, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5bd51274_0cceba5d PS60, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/b74f72ab_f1251b25 PS60, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/a9bcc326_60cefcb6 PS60, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/f8b4e3b2_2b8b4dae PS60, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/990f4175_25370447 PS60, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/bdc710f7_215303f3 PS60, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5bba8af4_a69bbb30 PS60, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/540b1f63_2b7cf03f PS60, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/0d235439_95ce25fe PS60, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/adea9483_0228e254 PS60, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/89ce05ee_328468a3 PS60, Line 34: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/69885072_cf2084f9 PS60, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/7360cc24_dcc3e988 PS60, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/41beaafb_972c8656 PS60, Line 73: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/d61c8fbf_d27b804e PS60, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/696d66f6_46181bb3 PS60, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/aad7d043_2c41204c PS60, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/6c0f4238_cb06f96d PS60, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/ad86df4a_e5f4ff3b PS60, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/3c5e7c80_551211c5 PS60, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5afd6433_63192e4e PS60, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/acd5d0ff_6944fa0c PS60, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/f36539f2_105ae6f8 PS60, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/54508aea_a9ada9bb PS60, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/210628c6_cdd37356 PS60, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/d15645f2_5efd2b22 PS60, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/2c4bb4d2_11d391b3 PS60, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/2ac2c19e_029e8b9c PS60, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/ba0fe983_ff3f6918 PS60, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/9bc2e2cc_980746c5 PS60, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/29913ea2_9152268f PS60, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/12664c04_795dc92d PS60, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/4910fa9a_055bbca7 PS60, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5a4058db_91d812ac PS60, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/90ca7863_f30565fb PS60, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/76b67cb0_4384db41 PS60, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/1bbaff45_7845505b PS60, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/dae79e8d_a76711a6 PS60, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/597346d9_c4cd1ede PS60, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/173e11aa_6a23a84a PS60, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/fbd689b3_fb0a6d49 PS60, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5e436f7c_c1baf2c1 PS60, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const