John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44185 )
Change subject: drivers/usb: Avoid value overwritten before its usage
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
Patch Set 2: Code-Review+1
git blame shows that `//return ret` line has been there for 9 years... and it sure looks wrong.
I wonder if this patch as-is breaks the try_next_port logic.
Then what about keeping "//return ret"? It would keep original logic and get rid of the defect as detected by Coverity.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e1fb5400ff64c6178bb30601896780f8d67b5c6
Gerrit-Change-Number: 44185
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 06 Aug 2020 16:14:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment