Attention is currently required from: Furquan Shaikh, Matt DeVillier.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48859 )
Change subject: ec/google/chromeec: Guard battery-related ACPI code ......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/48859/comment/0848153a_68101f6b PS1, Line 266: EC_NO_BATTERY_PRESENT
these are _Q methods, they are called by the OS, no?
These _Qxx methods are EC queries. Can't recall how the exact mechanism works, but the EC pokes the host (via SCI?) and tells it to run one of these EC query methods.
If the EC asks the OS to invoke an EC query method for battery-related stuff when the device does not support batteries, it indicates the EC firmware thinks this device can have a battery, which is most likely a bug in the EC firmware. That's why Furquan wanted to leave the debug prints in: it would make debugging such things easier.