Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33678 )
Change subject: Makefile: Use -Wold-style-definition
......................................................................
Patch Set 1:
Did you look at fixing the problems in src/cpu/x86/smm/smm_module_handler.c?
We've got 2 definitions there that are probably pulled into every x86 platform.
void __weak northbridge_smi_handler() {}
void __weak southbridge_smi_handler() {}
I looked at a couple of platforms, and those were the only 2 issues I saw, despite the overwhelming number of failures.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb
Gerrit-Change-Number: 33678
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 22 Jun 2019 17:29:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment