Attention is currently required from: Anjaneya "Reddy" Chagam, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Michael Niewöhner, Morgan Jang, Andrey Petrov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55114 )
Change subject: [RFC]src/soc/intel/common/block/pmc: Don't link get_int_option in SMM
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55114/comment/e89ed308_46fcd425
PS1, Line 7: int
*u*int since CB:52672 happened
https://review.coreboot.org/c/coreboot/+/55114/comment/b5378184_a52e63e0
PS1, Line 7: src/
nit: drop `src/`
https://review.coreboot.org/c/coreboot/+/55114/comment/f66da843_c815542e
PS1, Line 14: SMM handler
over 72 characters
https://review.coreboot.org/c/coreboot/+/55114/comment/b7b74f2d_7cd48ed4
PS1, Line 16: including
over 72 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60986979d7f7905b312b7d03abd46ac0465ae4cf
Gerrit-Change-Number: 55114
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 12:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment