Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32760 )
Change subject: soc/intel/broadwell: Clean up the bootflow ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/32760/1/src/mainboard/google/auron/romstage.... File src/mainboard/google/auron/romstage.c:
https://review.coreboot.org/#/c/32760/1/src/mainboard/google/auron/romstage.... PS1, Line 41: } oops, `pei_data` is gone :-/
https://review.coreboot.org/#/c/32760/1/src/mainboard/google/auron/romstage.... PS1, Line 46: _entry Change makes the weird naming obvious ;)
https://review.coreboot.org/#/c/32760/1/src/soc/intel/broadwell/romstage/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/#/c/32760/1/src/soc/intel/broadwell/romstage/rom... PS1, Line 125: /* Entry from the mainboard. */ Not true anymore.
https://review.coreboot.org/#/c/32760/1/src/soc/intel/broadwell/romstage/rom... PS1, Line 126: void romstage_common(struct romstage_params *params) Maybe merge it into romstage_main()?
https://review.coreboot.org/#/c/32760/1/src/soc/intel/broadwell/romstage/rom... PS1, Line 128: post_code(0x32); Redundant with some mainboards.