Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35189/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35189/5//COMMIT_MSG@7
PS5, Line 7: util/inteltool: inteltool extensions
Please make it a statement by adding a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/35189/5//COMMIT_MSG@8
PS5, Line 8:
So it’s mostly Intel Sunrise stuff? Could you elaborate a little?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6
Gerrit-Change-Number: 35189
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Sep 2019 20:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment