build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33067 )
Change subject: soc/intel/common: Add SMBIOS type 131 fields ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/cse/cse.c File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/cse/cse.c... PS2, Line 793: switch (platf_type.brand) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/cse/cse.c... PS2, Line 860: struct smbios_type131 *type131) code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/cse/cse.c... PS2, Line 860: struct smbios_type131 *type131) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/cse/cse.c... PS2, Line 968: int *handle, unsigned long *current) code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/cse/cse.c... PS2, Line 968: int *handle, unsigned long *current) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/include/i... PS2, Line 209: } __packed ; space prohibited before semicolon
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/include/i... PS2, Line 224: struct smbios_type131 *type131); code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/2/src/soc/intel/common/block/include/i... PS2, Line 224: struct smbios_type131 *type131); please, no spaces at the start of a line