[coreboot-gerrit] Change in coreboot[master]: device/Kconfig: Add HAVE_EXT_GFX kconfig

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )

Change subject: device/Kconfig: Add HAVE_EXT_GFX kconfig
......................................................................

Patch Set 8: Code-Review-1

(1 comment)

-1 as the introduced Kconfig options has no benefit and only confuses users.
It increases fragmentation and depends on board specific code for no reason.
It mixes preferred GPU selection on multi GPU setup platforms with legacy graphics initialisation features in coreboot.

https://review.coreboot.org/c/coreboot/+/33738/6/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/33738/6/src/device/Kconfig@133 
PS6, Line 133: 	  graphics card and selecting this Kconfig will ask FSP to make IGD disable.
> I'm afraid that your assumption is not correct, with UEFI BIOS on Lenovo Thinkpad that I'm using is  […]

That's how it works in coreboot.