Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29414 )
Change subject: soc/intel/braswell: Include LPE ACPI code in mainboard
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/29414/10/src/mainboard/google/cyan/dsdt.asl
File src/mainboard/google/cyan/dsdt.asl:
https://review.coreboot.org/#/c/29414/10/src/mainboard/google/cyan/dsdt.asl@...
PS10, Line 7: * Copyright (C) 2019 Eltan B.V.
Is this contribution really worth adding a copyright line? Is it a "Creative and significant" contribution? While I don't disagree that it's copyrightable, I'd ask you to consider whether it's reasonable and only add a copyright line when it's actually significant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8acf9ea9e9b0ba9b272e20beb2023b7a4716a73
Gerrit-Change-Number: 29414
Gerrit-PatchSet: 10
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 20 Apr 2019 04:33:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment