[coreboot-gerrit] [XS] Change in coreboot[master]: soc/amd/common/data_fabric_helper: use DF broadcast read/write functions

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76887?usp=email )

Change subject: soc/amd/common/data_fabric_helper: use DF broadcast read/write functions
......................................................................

soc/amd/common/data_fabric_helper: use DF broadcast read/write functions

Instead of open coding the broadcast data fabric PCI register access in
the functions for indirect non-broadcast data fabric register access,
just use the existing data_fabric_broadcast_[read,write]32 functions.

Signed-off-by: Felix Held 
Change-Id: I174c1e6ee4856d97c5ec6d07bb8c217d6df9425f
---
M src/soc/amd/common/block/data_fabric/data_fabric_helper.c
1 file changed, 3 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/76887/1

diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c
index b0b98ea..2fb1c04 100644
--- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c
+++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c
@@ -18,8 +18,7 @@
    ficaa.reg_num = DF_REG_REG(fn_reg) >> 2;
    ficaa.func_num = DF_REG_FN(fn_reg);
    ficaa.inst_id = instance_id;
-	pci_write_config32(_SOC_DEV(DF_DEV, DF_REG_FN(DF_FICAA_BIOS)),
-			   DF_REG_REG(DF_FICAA_BIOS), ficaa.raw);
+	data_fabric_broadcast_write32(DF_FICAA_BIOS, ficaa.raw);
 }

uint32_t data_fabric_read32(uint16_t fn_reg, uint8_t instance_id)
@@ -31,8 +30,7 @@

/* non-broadcast data fabric accesses need to be done via indirect access */
    data_fabric_set_indirect_address(fn_reg, instance_id);
-	return pci_read_config32(_SOC_DEV(DF_DEV, DF_REG_FN(DF_FICAD_LO)),
-				 DF_REG_REG(DF_FICAD_LO));
+	return data_fabric_broadcast_read32(DF_FICAD_LO);;
 }

void data_fabric_write32(uint16_t fn_reg, uint8_t instance_id, uint32_t data)
@@ -44,8 +42,7 @@

/* non-broadcast data fabric accesses need to be done via indirect access */
    data_fabric_set_indirect_address(fn_reg, instance_id);
-	pci_write_config32(_SOC_DEV(DF_DEV, DF_REG_FN(DF_FICAD_LO)),
-			   DF_REG_REG(DF_FICAD_LO), data);
+	data_fabric_broadcast_write32(DF_FICAD_LO, data);
 }

void data_fabric_print_mmio_conf(void)