Nico Huber has posted comments on this change. ( https://review.coreboot.org/28862 )
Change subject: sb/intel/common: Add common reset handler ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/common/reset.c File src/southbridge/intel/common/reset.c:
https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/common/reset.c... PS2, Line 28: FULL_RST This would issue a power-cycle reset, which is usually unwanted. I'm also not sure if it's valid to set it w/o SYS_RST.
Also worth to mention: I've seen different patterns regarding this register. Older platforms set the configuration bits (FULL_RST and or SYS_RST) first and then again with RST_CPU in a second outb(). It's still unclear (also not documented explicitly) if this is needed, but it doesn't hurt. So I'd prefer two outb() calls unless _all_ affected platforms did a single call before.