Attention is currently required from: Furquan Shaikh, Arthur Heymans, Andrey Petrov, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55142 )
Change subject: FSP2.0 platforms: Use bootloader reserved memory for BERT
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/55142/comment/39e9af16_c4befe4e
PS3, Line 40: * +---------------------------+ TOLUM / top_of_ram / cbmem_top
update comment
Done
https://review.coreboot.org/c/coreboot/+/55142/comment/cc575205_cfb08c8e
PS3, Line 61: *start = cbmem_top();
: *size = CONFIG_ACPI_BERT_SIZE;
Just wondering: this ends up being UC instead of WB: see systemagent.c 'top_of_ram -> TOLUD'. […]
Yeah that makes sense to me, the extra MTRR is not necessary
`MTRR: 1 base 0x0000000076ff0000 mask 0x00003fffffff0000 type 0`
is what I got on my machine for that region, next patch will account for that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd99fc4a89d559be32be69f8fc73c30782e6ae97
Gerrit-Change-Number: 55142
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 21:51:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment