Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 5: panel-AUO_B101UAN08_3
sort alphabetically (i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 4: Huaqin
Are you sure?
Done
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 25: .name = "1200x1920@60Hz",
do not declare name here.
Done
https://review.coreboot.org/c/coreboot/+/35001/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:
https://review.coreboot.org/c/coreboot/+/35001/4/src/mainboard/google/kukui/... PS4, Line 18: static
you cannot put static.
Done