Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47988 )
Change subject: soc/intel/common/dmi: Add DMI driver support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47988/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/dmi/dmi.c:
https://review.coreboot.org/c/coreboot/+/47988/1/src/soc/intel/common/block/...
PS1, Line 8: 2
I was using it as 0-2 (3). I can change it to 3 and do 1-3, let me know. […]
Index can be 0-2, but MAX_ always refers to the actual count. So, it would be better to set this to 3 and use i = 0; i < MAX_GPMR_REGS; i++ below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34a894e295ecb98fbc4a81282361e851c436a403
Gerrit-Change-Number: 47988
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Nov 2020 19:55:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-MessageType: comment