[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Init SPM driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )

Change subject: mediatek/mt8183: Init SPM driver
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34545/12/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34545/12/src/mainboard/google/kukui... 
PS12, Line 59: spm_init(get_dram_type());
> I don't think this will work. […]

Please try not to call get_sdram_config() from ramstage, it will have to load the whole blob from SPI flash again. Is there no way you can just determine the DRAM type by reading back some EMI registers (similar to how sdram_size() is implemented)? That's usually the best way to make that work.

(Alternatively, if there's no better way to do this, maybe load the SPM at the end of romstage instead?)