18 Feb
2019
18 Feb
'19
2:07 p.m.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31444 )
Change subject: soc/intel/cannonlake: Add ASL function for setting pad mode ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31444/2/src/soc/intel/cannonlake/acpi/gpio_o... File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/#/c/31444/2/src/soc/intel/cannonlake/acpi/gpio_o... PS2, Line 91: PADM, 2,
IIRC, in the past we have had problems accessing individual bit fields in 32-bit regs. […]
Can you point me to the bug, I am not aware of this issue. Didn't see any issues with the pad config here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31444
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c683f27ddffc3132001706d1694c71bb5664577
Gerrit-Change-Number: 31444
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 18 Feb 2019 13:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment