Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki. Hello build bot (Jenkins), Raul Rangel, Nico Huber, Patrick Georgi, Kyösti Mälkki,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61308
to look at the new patch set (#6).
Change subject: console: Add loglevel marker codes to stored consoles ......................................................................
console: Add loglevel marker codes to stored consoles
In order to provide the same loglevel prefixes and highlighting that were recently introduced for "interactive" consoles (e.g. UART) to "stored" consoles (e.g. CBMEM) but minimize the amont of extra storage space wasted on this info, this patch will write a 1-byte control character marker indicating the loglevel to the start of every line logged in those consoles. The `cbmem` utility will then interpret those markers and translate them back into loglevel prefixes and escape sequences as needed.
Since coreboot and userspace log readers aren't always in sync, occasionally an older reader may come across these markers and not know how to interpret them... but that should usually be fine, as the range chosen contains non-printable ASCII characters that normally have no effect on the terminal. At worst the outdated reader would display one garbled character at the start of every line which isn't that bad. (Older versions of the `cbmem` utility will translate non-printable characters into `?` question marks.)
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I86073f48aaf1e0a58e97676fb80e2475ec418ffc --- M src/commonlib/include/commonlib/loglevel.h M src/console/printk.c M util/cbmem/cbmem.c 3 files changed, 43 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/61308/6