Attention is currently required from: Erik van den Bogaert, Felix Singer, Frans Hendriks, Maxim Polyakov.
Harrie Paijmans has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
Change subject: superio/fintek: Add support for f81966d ......................................................................
Patch Set 2:
(5 comments)
File src/superio/fintek/f81966d/f81966d_gpio.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/74994708_f573d613?usp... : PS1, Line 14: */
space before */
added space
https://review.coreboot.org/c/coreboot/+/87198/comment/c23f9956_3fa9a8d2?usp... : PS1, Line 15: setreg
set_reg to match the сode style
renamed symbol
https://review.coreboot.org/c/coreboot/+/87198/comment/46f28c67_a81e7fbf?usp... : PS1, Line 25: selectbank
select_bank
renamed symbol
https://review.coreboot.org/c/coreboot/+/87198/comment/b2b4dbb7_ec68c0c7?usp... : PS1, Line 58: selectbank
Do we really have to set a bank for each setreg()? […]
indeed, this was initially done to be inline with the datasheet. Refactored the writes to minimize switches between banks.
File src/superio/fintek/f81966d/superio.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/a4dcf60c_810e391d?usp... : PS1, Line 58: Some of the 0x7f8 values may need to be corrected
Mark it as `TODO: ... […]
added TODO: