[coreboot-gerrit] [L] Change in coreboot[master]: src/device + util/sconfig: Introduce new device 'mdio'

[Arthur Heymans (Code Review)]

Attention is currently required from: Martin L Roth, Subrata Banik, Mario Scheithauer, Angel Pons, Werner Zeh.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 )

Change subject: src/device + util/sconfig: Introduce new device 'mdio'
......................................................................

Patch Set 5:

(1 comment)

File src/include/device/path.h:

https://review.coreboot.org/c/coreboot/+/69382/comment/444be0a0_c7152492 
PS5, Line 117: struct mdio_path {
             : 	unsigned int addr;
             : };
> Indeed gcc checks for the vaid range and complains if it does not fir:
>
> build/mainboard/siemens/mc_ehl/static.c:1021:51: error: unsigned conversion from 'int' to 'unsigned char:5' changes value from '33' to '1' [-Werror=overflow]
>   .path = {.type=DEVICE_PATH_MDIO,{.mdio={ .addr = 0x21 }}},
>
> I can push a follow-up patch once this train is in.

Cool! A follow-up is fine.