build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32290 )
Change subject: Klocwork: Fix the Null pointer derefernce found by klocwork ......................................................................
Patch Set 2:
(15 comments)
https://review.coreboot.org/#/c/32290/2/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/32290/2/src/lib/coreboot_table.c@236 PS2, Line 236: if(wd) code indent should use tabs where possible
https://review.coreboot.org/#/c/32290/2/src/lib/coreboot_table.c@236 PS2, Line 236: if(wd) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32290/2/src/lib/coreboot_table.c@236 PS2, Line 236: if(wd) that open brace { should be on the previous line
https://review.coreboot.org/#/c/32290/2/src/lib/coreboot_table.c@236 PS2, Line 236: if(wd) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32290/2/src/lib/coreboot_table.c@237 PS2, Line 237: { trailing whitespace
https://review.coreboot.org/#/c/32290/2/src/lib/string.c File src/lib/string.c:
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@9 PS2, Line 9: if(d) trailing whitespace
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@9 PS2, Line 9: if(d) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@19 PS2, Line 19: if(d) trailing whitespace
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@19 PS2, Line 19: if(d) code indent should use tabs where possible
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@19 PS2, Line 19: if(d) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@19 PS2, Line 19: if(d) that open brace { should be on the previous line
https://review.coreboot.org/#/c/32290/2/src/lib/string.c@19 PS2, Line 19: if(d) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32290/2/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/#/c/32290/2/src/security/vboot/common.c@79 PS2, Line 79: if(wd) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32290/2/src/soc/intel/broadwell/ramstage.c File src/soc/intel/broadwell/ramstage.c:
https://review.coreboot.org/#/c/32290/2/src/soc/intel/broadwell/ramstage.c@3... PS2, Line 34: if(!ps) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32290/2/util/cbfstool/cbfs_sections.c File util/cbfstool/cbfs_sections.c:
https://review.coreboot.org/#/c/32290/2/util/cbfstool/cbfs_sections.c@68 PS2, Line 68: if(!list_node) space required before the open parenthesis '('