[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add support for UART2 on PCH-H

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )

Change subject: soc/intel/cannonlake: Add support for UART2 on PCH-H
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40405/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40405/2//COMMIT_MSG@15 
PS2, Line 15: Linux
> What version?

Done

https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/ac... 
File src/soc/intel/cannonlake/acpi/serialio.asl:

https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/ac... 
PS2, Line 72:
> double newline

Done

https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/pc... 
File src/soc/intel/cannonlake/pch_h.c:

https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/pc... 
PS2, Line 24: 	printk(BIOS_ERR, "ACPIGEN: %s\n", acpi_device_name(dev));
> should this be BIOS_ERR?

Removed