Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47882 )
Change subject: util/cbfstool: Add support for mapping extended window for x86 platforms ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47882/8/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47882/8/util/cbfstool/cbfstool.c@17... PS8, Line 171: 16 * MiB this and the 4ULL*GiB (originally from the previous patch but could just be done in this one) might be good to put into #define as standard/default PC expectations for mmapped flash.
https://review.coreboot.org/c/coreboot/+/47882/8/util/cbfstool/cbfstool.c@18... PS8, Line 183: /* this is all very helpful for understanding the implementation. I wish we had a cbfstool doc it could be added to, but perhaps you could create a separate doc about the extended window support that mostly just repeated what is in all the various comments from the patchset.