[coreboot-gerrit] Change in coreboot[master]: drivers/generic/ioapic: Use arch/x86/ioapic

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55185 )

Change subject: drivers/generic/ioapic: Use arch/x86/ioapic
......................................................................

Patch Set 3:

(1 comment)

File src/drivers/generic/ioapic/ioapic.c:

https://review.coreboot.org/c/coreboot/+/55185/comment/34235380_dc80cf26 
PS3, Line 17: 			config->enable_virtual_wire);
I doubt if irq_on_fsb is worth keeping in devicetree. Usage is bound to CPU model AFAICS.

I am not convinced when one is allowed to leave enable_virtual_wire unselected. It's a bit confusing and needs better documentation. There is unconditional LINT0/1 virtual wire also in cpu/x86/lapic/lapic.c that is legacy PCI i8259 related.