[coreboot-gerrit] Change in coreboot[master]: intel/common/mmc: Provide mmc.c for setting dll registers.

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )

Change subject: intel/common/mmc: Provide mmc.c for setting dll registers.
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/scs/mmc.c:

https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... 
PS2, Line 22: mainboard_get_mmc_dll
> i would have expect this call to go into soc code and soc code gets required value from chip. […]

sounds good.
then , every proj can put dll value in devicetree.cb and it can also be used once the new FSP has dll UPDs is landed

https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... 
PS2, Line 27: ioaddr
> why you are calling this as ioaddress ? rather calling as BAR ?

will fix this