Attention is currently required from: Kapil Porwal, Nick Vaccaro, Pranava Y N, Subrata Banik.
Avi Uday has posted comments on this change by Avi Uday. ( https://review.coreboot.org/c/coreboot/+/87351?usp=email )
Change subject: mb/google/ocelot: Update Ocelot board ......................................................................
Patch Set 7:
(4 comments)
File src/mainboard/google/ocelot/Kconfig:
https://review.coreboot.org/c/coreboot/+/87351/comment/70a023c0_56345796?usp... : PS4, Line 65:
empty line ?
Done
https://review.coreboot.org/c/coreboot/+/87351/comment/3f868fad_9007b3a3?usp... : PS4, Line 66: select EC_GOOGLE_CHROMEEC_MEC : select MAINBOARD_USES_IFD_EC_REGION
please check with Ocelet SKU matrix and find out if we need to support MEC EC chip or not ? otherwis […]
Done
File src/mainboard/google/ocelot/variants/ocelot/fw_config.c:
https://review.coreboot.org/c/coreboot/+/87351/comment/7dc39b61_b057bc00?usp... : PS4, Line 343: >>>>>>> 8b036f22cc (mb/google/ocelot: Update Ocelot board)
`spaces required around that ':' (ctx:VxW)` […]
Done
File src/mainboard/google/ocelot/variants/ocelot/fw_config.c:
https://review.coreboot.org/c/coreboot/+/87351/comment/993e0a5f_9b5a40fc?usp... : PS5, Line 608: TOUCHSCREEN_GSPI
can you please check if this code is buildable ? mostly not so, because CB:87310 has dropped TOUCHSC […]
Will check