Hello Kaiyen Chang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48302
to review the following change.
Change subject: soc/intel/common/gpio_defs: Add a macro for EDGE_BOTH trigger pad ......................................................................
soc/intel/common/gpio_defs: Add a macro for EDGE_BOTH trigger pad
Adds a new macro to configure the pad to EDGE_BOTH trigger mode.
BUG=b:174336541 TEST=emerge-dedede coreboot
Signed-off-by: Kaiyen Chang kaiyen.chang@intel.corp-partner.google.com Change-Id: Icc805f5cfe45e5cc991fb0561f669907ac454a03 --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/48302/1
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h index 422720b..f082470 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h @@ -276,6 +276,12 @@ PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE), \ PAD_PULL(pull) | PAD_CFG_OWN_GPIO(DRIVER) | PAD_IOSSTATE(TxDRxE))
+#define PAD_CFG_GPI_GPIO_DRIVER_EDGE_BOTH(pad, pull, rst) \ + _PAD_CFG_STRUCT(pad, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE) | \ + PAD_CFG0_TRIG_EDGE_BOTH, \ + PAD_PULL(pull) | PAD_CFG_OWN_GPIO(DRIVER) | PAD_IOSSTATE(TxDRxE)) + #define PAD_CFG_GPIO_DRIVER_HI_Z(pad, pull, rst, iosstate, iosterm) \ _PAD_CFG_STRUCT(pad, \ PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_RX_DISABLE), \