Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45344 )
Change subject: soc/intel/common/block/cpu: Fix boot failure ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/... PS1, Line 349: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX)) : return 0;
CB:45345 would allow PRMRRs to be set without SGX
Well, if PRMRR isn't SGX-specific, then it should be moved out of SGX Kconfig.
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/... PS1, Line 352: if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED)) { : printk(BIOS_DEBUG, "PRMRR disabled by config.\n"); : return 0; : }
What's this for, then?
It doesn't get set because CNL doesn't select SOC_INTEL_COMMON_BLOCK_SGX