Aaron Durbin (adurbin@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5701
-gerrit
commit 7cf4de0750047ccd45be9b66e4e7b118d4f8e58a Author: Aaron Durbin adurbin@chromium.org Date: Thu May 8 11:14:41 2014 -0500
toolchain: get rid of some bashisms
On Ubuntu /bin/sh is symlinked to /bin/dash. The current toolchain.inc was doing some things that dash doesn't support. Make the shell callouts more conforming to the POSIX sh standard.
Change-Id: I26b6b82b8d6158c9029e8be9e7c088ca9e207f21 Signed-off-by: Aaron Durbin adurbin@chromium.org --- toolchain.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/toolchain.inc b/toolchain.inc index 649d203..576e744 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -66,14 +66,14 @@ STRIP_$(1) := $(STRIP_$(2)) READELF_$(1) := $(READELF_$(2)) INCLUDES_$(1) = -Isrc/arch/$(ARCHDIR-$(2))/include CFLAGS_$(1) = $$(CFLAGS_common) $$(INCLUDES_$(1)) $(CFLAGS_$(2)) -LIBGCC_FILE_NAME_$(1) = $(shell test -r `$(CC_$(2)) -print-libgcc-file-name` && \ +LIBGCC_FILE_NAME_$(1) = $(shell [ -r `$(CC_$(2)) -print-libgcc-file-name` ] && \ $(CC_$(2)) -print-libgcc-file-name) endef
# initialize standard toolchain (CC,AS and others) for give stage # @1 : stage for which the toolchain is to be initialized init_standard_toolchain = \ - $(eval stage_caps := $(shell tr '[:lower:]' '[:upper:]' <<< $(1))) \ + $(eval stage_caps := $(shell printf "%s" $(1) | tr '[:lower:]' '[:upper:]' )) \ $(eval $(call set_stage_toolchain,$(stage_caps))) \ $(eval $(call create_class_compiler,$(1),$(ARCH-$(stage_caps)-y))) \ $(eval $(call set_stage_libgcc,$(1)))