Attention is currently required from: Felix Singer, Furquan Shaikh, Paul Menzel, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58079 )
Change subject: soc/intel/skl: mark C-state C2 as insupported in FADT
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58079/comment/cb12b4c9_3d7305e7
PS2, Line 7: insupported
typo: *u*nsupported
https://review.coreboot.org/c/coreboot/+/58079/comment/0b4343a9_0b6b3c70
PS2, Line 9: Kabylake
The official spelling is `Kaby Lake`. While at it, I'd avoid using a slash with this:
Skylake and Kaby Lake CPUs don't support C-state C2.
https://review.coreboot.org/c/coreboot/+/58079/comment/078cd63e_5058bdb4
PS2, Line 9: is
typo: as
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdbf770941dbdf757e7189e999d222a72412002d
Gerrit-Change-Number: 58079
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 04 Oct 2021 12:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment