6 Jul
2021
6 Jul
'21
12:41 p.m.
Attention is currently required from: Krishna Prabhakaran, Selma Bensaid, Meera Ravindranath, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ......................................................................
Patch Set 10:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/7dcdf172_0f3494a2 PS10, Line 151: default 0x200
Does the OpRegion version need to be specified in hex? I feel having specific Kconfig options for th […]
To handle the different RVDA meaning, as we don't support Opregion versions earlier than 2.0, I'd just check for `INTEL_GMA_OPREGION_2_0`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52758
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b
Gerrit-Change-Number: 52758
Gerrit-PatchSet: 10
Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Krishna Prabhakaran krishna.prabhakaran@intel.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Krishna Prabhakaran krishna.prabhakaran@intel.com
Gerrit-Attention: Selma Bensaid selma.bensaid@intel.com
Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 06 Jul 2021 10:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment