Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34705 )
Change subject: mb/google/helios: Set SPKR_PA_EN PIN high for boot beep ......................................................................
mb/google/helios: Set SPKR_PA_EN PIN high for boot beep
This patch makes SPKR_PA_EN PIN output and high for boot beep to work in pre-os environment.
BUG=b:135104721 BRANCH=NONE TEST=Boot Beep is working with required ALC1011 depthcharge code changes.
Change-Id: I012462f93e9e2bcafe5f18ce7d04e3fcd1db9ffa Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34705 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Usha P usha.p@intel.com Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Meera Ravindranath meera.ravindranath@intel.corp-partner.google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Sathya Prakash M R sathya.prakash.m.r@intel.com --- M src/mainboard/google/hatch/variants/helios/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified V Sowmya: Looks good to me, approved Sathya Prakash M R: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Usha P: Looks good to me, but someone else must approve Meera Ravindranath: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/helios/gpio.c b/src/mainboard/google/hatch/variants/helios/gpio.c index ecb13f3..257b020 100644 --- a/src/mainboard/google/hatch/variants/helios/gpio.c +++ b/src/mainboard/google/hatch/variants/helios/gpio.c @@ -85,6 +85,8 @@ PAD_NC(GPP_G5, NONE), /* G6 : GPP_G6 ==> NC */ PAD_NC(GPP_G6, NONE), + /* H3 : SPKR_PA_EN */ + PAD_CFG_GPO(GPP_H3, 1, DEEP), /* H4 : I2C2_SDA ==> NC */ PAD_NC(GPP_H4, NONE), /* H5 : I2C2_SCL ==> NC */