Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30989 )
Change subject: intelblocks/systemagent: Add ACPI table generation hook ......................................................................
Patch Set 3:
(3 comments)
converging...
https://review.coreboot.org/#/c/30989/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30989/3//COMMIT_MSG@11 PS3, Line 11: event the entry hook `the entry hook event`?
https://review.coreboot.org/#/c/30989/2/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/#/c/30989/2/src/soc/intel/common/block/include/i... PS2, Line 79: const
Wait a moment, in device/device.h the function prototype for this hook does not use const at all: […]
looks fine to me now in the patchset 3
https://review.coreboot.org/#/c/30989/3/src/soc/intel/common/block/systemage... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/3/src/soc/intel/common/block/systemage... PS3, Line 23: #include <intelblocks/acpi.h> : #include <soc/iomap.h> : #include "systemagent_def.h" : #include <soc/pci_devs.h> now the order looks, hm, random to me