[coreboot-gerrit] Change in coreboot[master]: mb/mainboard/herobrine: Initialize SPI FW for EC and TPM

[Julius Werner (Code Review)]

Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Rajesh Patil.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )

Change subject: mb/mainboard/herobrine: Initialize SPI FW for EC and TPM
......................................................................

Patch Set 88:

(1 comment)

File src/mainboard/google/herobrine/Kconfig:

https://review.coreboot.org/c/coreboot/+/50581/comment/3554b8f7_385b2620 
PS84, Line 66: 	default 0xC if BOARD_GOOGLE_HEROBRINE
> I think that this should never be true?

...why wouldn't it? It's true exactly iff you're building for Herobrine (the reference board).

But, honestly, this stuff should allow a default case rather than requiring every board to be specified exactly. Piglin and Hoglin are the odd ones out, everything else should follow the layout of the Herobrine reference design. So this should be written as

hex
 default 0xE if BOARD_GOOGLE_PIGLIN || BOARD_GOOGLE_HOGLIN
 default 0xC

and then you won't need to update it every time someone adds a new Herobrine variant. (Same goes for EC_GOOGLE_CHROMEEC_SPI_BUS.)