Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40029 )
Change subject: include/input-event-codes.h: Add Linux input key codes header file
......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 4:
(1 comment)
Why does this information need to be in ACPI? The Linux driver (and every other OS) could get the mappings also, couldn’t it?
The kernel expects mappings of scancodes to keycodes. Since the mappings a system needs depends on which keys are present, and is thus platform knowledge,
For internal keyboards 😊
thus it is residing in the ACPI. Yes, these ACPI mappings shall be available to any OS that boot using the coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40051cb63a6c154728887ac9b0521bc671b2a518
Gerrit-Change-Number: 40029
Gerrit-PatchSet: 5
Gerrit-Owner: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 22:44:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment