build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48872 )
Change subject: soc/intel/common: move "pmc_gpe_init" to the beginning of "verstage" ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... File src/soc/intel/apollolake/verstage.c:
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 1: #include <security/vboot/vboot_common.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 2: #include <intelblocks/pmclib.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 3: DOS line endings
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 4: void verstage_soc_init(void) DOS line endings
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 5: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 6: pmc_gpe_init(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 6: pmc_gpe_init(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/48872/1/src/soc/intel/apollolake/ve... PS1, Line 7: } DOS line endings