build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32054 )
Change subject: nb/intel/pineview: Correct unsigned integer check in msbpos
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32054/1/src/northbridge/intel/pineview/ramin...
File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/#/c/32054/1/src/northbridge/intel/pineview/ramin...
PS1, Line 339: for (i = 7; (i != 0) && ((val & (1 << i)) == 0); i--);
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5be50846cc545dcd48593e5ed3fd6068a6104cb
Gerrit-Change-Number: 32054
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Mar 2019 00:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment