Balaji Manigandan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )
Change subject: site-local: Allow to read Makefile.inc w/o .config
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34024/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34024/1//COMMIT_MSG@9
PS1, Line 9: Makefile.inc allows to extend site specific configurations
: list the make options irrespective of a .config
Please add dot/periods at the end of sentences.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187
Gerrit-Change-Number: 34024
Gerrit-PatchSet: 2
Gerrit-Owner: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jul 2019 15:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment