Change in coreboot[master]: site-local: Allow to read Makefile.inc w/o .config

List overview All Threads
Download

newer

older

Change in libgfxinit[master]: gma:...

Change in coreboot[master]:...

Balaji Manigandan (Code Review)

3 Jul 2019 3 Jul '19

5:49 p.m.

Balaji Manigandan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

site-local: Allow to read Makefile.inc w/o .config

Makefile.inc allows to extend site specific configurations list the make options irrespective of a .config

Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Signed-off-by: Balaji Manigandan B balaji.manigandan@intel.com --- M Makefile 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/34024/1

diff --git a/Makefile b/Makefile index 45b0bc5..dfc70e0 100644 --- a/Makefile +++ b/Makefile @@ -129,11 +129,12 @@ endif endif

+-include $(TOPLEVEL)/site-local/Makefile.inc + ifeq ($(NOCOMPILE),1) include $(TOPLEVEL)/Makefile.inc include $(TOPLEVEL)/payloads/Makefile.inc include $(TOPLEVEL)/util/testing/Makefile.inc --include $(TOPLEVEL)/site-local/Makefile.inc real-all: @echo "Error: Expected config file ($(DOTCONFIG)) not present." >&2 @echo "Please specify a config file or run 'make menuconfig' to" >&2

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Balaji Manigandan (Code Review)

16 Jul 16 Jul

8:12 a.m.

Balaji Manigandan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

Patch Set 1:

@Patrick, @Martin : could you please check this patch ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 1 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jul 2019 06:12:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

2:11 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/34024/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34024/1//COMMIT_MSG@9 PS1, Line 9: Makefile.inc allows to extend site specific configurations : list the make options irrespective of a .config Please add dot/periods at the end of sentences.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 1 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jul 2019 12:11:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Balaji Manigandan (Code Review)

5:29 p.m.

Hello Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34024

to look at the new patch set (#2).

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

site-local: Allow to read Makefile.inc w/o .config

Makefile.inc allows extending site-specific configurations. This change is to allow make utility to list supported options, irrespective of a .config file availability

Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Signed-off-by: Balaji Manigandan B balaji.manigandan@intel.com --- M Makefile 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/34024/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 2 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Balaji Manigandan (Code Review)

5:30 p.m.

Balaji Manigandan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34024/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34024/1//COMMIT_MSG@9 PS1, Line 9: Makefile.inc allows to extend site specific configurations : list the make options irrespective of a .config

...

Please add dot/periods at the end of sentences.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 2 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jul 2019 15:30:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Balaji Manigandan (Code Review)

5:30 p.m.

Hello Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34024

to look at the new patch set (#3).

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

site-local: Allow to read Makefile.inc w/o .config

Makefile.inc allows extending site-specific configurations. This change is to allow make utility to list supported options, irrespective of a .config file availability.

Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Signed-off-by: Balaji Manigandan B balaji.manigandan@intel.com --- M Makefile 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/34024/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 3 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Martin Roth (Code Review)

6 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 3 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jul 2019 16:00:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

17 Jul 17 Jul

6:05 p.m.

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

site-local: Allow to read Makefile.inc w/o .config

Makefile.inc allows extending site-specific configurations. This change is to allow make utility to list supported options, irrespective of a .config file availability.

Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Signed-off-by: Balaji Manigandan B balaji.manigandan@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34024 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M Makefile 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve

diff --git a/Makefile b/Makefile index 45b0bc5..dfc70e0 100644 --- a/Makefile +++ b/Makefile @@ -129,11 +129,12 @@ endif endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 4 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Patrick Georgi (Code Review)

2 Oct 2 Oct

12:28 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

Patch Set 4:

This leads to double evaluation of site-local/Makefile.inc in the NOCOMPILE==0 case: once here, once through subdirs-y.

What's the rationale for forcing it here as well instead of waiting for subdirs handling to kick in?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 4 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 02 Oct 2019 10:28:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

4 Oct 4 Oct

9:22 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34024 )

Change subject: site-local: Allow to read Makefile.inc w/o .config ......................................................................

Patch Set 4:

There is a revert change: CB:35786

-- To view, visit https://review.coreboot.org/c/coreboot/+/34024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c968c773c368ea74689b9741c4c978c35110187 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 4 Gerrit-Owner: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 04 Oct 2019 07:22:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1674

days inactive

1767

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Balaji Manigandan (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)