Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31548 )
Change subject: security: Add memory subfolder ......................................................................
Patch Set 8:
(7 comments)
https://review.coreboot.org/#/c/31548/3/Documentation/security/memory_cleari... File Documentation/security/memory_clearing.md:
https://review.coreboot.org/#/c/31548/3/Documentation/security/memory_cleari... PS3, Line 19: 2. Code that is placed in DRAM might be skipped (FSP1.0) : 3. Stack that is placed in DRAM might be skipped (FSP1.0)
Done
Ack
https://review.coreboot.org/#/c/31548/3/Documentation/security/memory_cleari... PS3, Line 37: As those regions are written on early boot and marked reserved from : OS point of view, it is unlikely that they contain secrets. :
Done
Ack
https://review.coreboot.org/#/c/31548/8/Documentation/security/memory_cleari... File Documentation/security/memory_clearing.md:
https://review.coreboot.org/#/c/31548/8/Documentation/security/memory_cleari... PS8, Line 15: The spurious?
https://review.coreboot.org/#/c/31548/3/src/security/memory/Kconfig File src/security/memory/Kconfig:
https://review.coreboot.org/#/c/31548/3/src/security/memory/Kconfig@3 PS3, Line 3: ## Copyright (C) 2019 Facebook Inc. : ## Copyright (C) 2019 9elements Agency GmbH
That's difficult as I've split the original proof of concept code into smaller patches, not taking c […]
Well, at least these notices would get a meaning, if Facebook would ever take over 9elements, or the other way around ;)
Until then, I fear, they aren't useful as you can't say for any line, who has copyright.
https://review.coreboot.org/#/c/31548/3/src/security/memory/memory.h File src/security/memory/memory.h:
https://review.coreboot.org/#/c/31548/3/src/security/memory/memory.h@4 PS3, Line 4: * Copyright (C) 2019 9elements Agency GmbH : * Copyright (C) 2019 Facebook Inc.
See other copyright comment
Ack
https://review.coreboot.org/#/c/31548/3/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/3/src/security/memory/memory.c@22 PS3, Line 22: USER
Done
Ack
https://review.coreboot.org/#/c/31548/8/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/8/src/security/memory/memory.c@27 PS8, Line 27: IS_ENABLED(CONFIG_ CONFIG(