Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39477 )
Change subject: mb/google/dedede: Enable Intel Speed Shift Technology
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39477/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39477/5/src/mainboard/google/dedede...
PS5, Line 12: /* Nothing to override */
It would be helpful to add a comment indicating when this is required to be implemented by a variant […]
Agreed. I will add a comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id65d7981501c2f282e564bfc140f8d499d5713e8
Gerrit-Change-Number: 39477
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 May 2020 19:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment