build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46882 )
Change subject: soc/intel/common/block/cse: Add functions to support setting DAM state ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46882/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/46882/3/src/soc/intel/common/block/... PS3, Line 956: if(heci_read_file_ex(MCA_DAM_FILE_ID, 0, &data_size, 0, dam_state) < 0){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/46882/3/src/soc/intel/common/block/... PS3, Line 956: if(heci_read_file_ex(MCA_DAM_FILE_ID, 0, &data_size, 0, dam_state) < 0){ space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/46882/3/src/soc/intel/common/block/... PS3, Line 957: printk(BIOS_ERR, "Failed to get DAM state \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/46882/3/src/soc/intel/common/block/... PS3, Line 971: if(!status) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/46882/3/src/soc/intel/common/block/... PS3, Line 977: int disable_dam(void){ open brace '{' following function definitions go on the next line