Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54953 )
Change subject: nb/intel/x4x/rcven.c: Guard macro parameters ......................................................................
nb/intel/x4x/rcven.c: Guard macro parameters
Add parentheses around macro parameters to avoid operation order issues.
Change-Id: I9528f3d6b221854fddd2db6d2b45c63bfdda0092 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54953 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/x4x/rcven.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c index d3b1b31..9e58ef3 100644 --- a/src/northbridge/intel/x4x/rcven.c +++ b/src/northbridge/intel/x4x/rcven.c @@ -10,7 +10,7 @@ #define DQS_HIGH 1 #define DQS_LOW 0
-#define RESET_CNTL(channel) (0x5d8 + channel * 0x400) +#define RESET_CNTL(channel) (0x5d8 + (channel) * 0x400)
struct rec_timing { u8 medium;