Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31684 )
Change subject: device/pci_ops: Simplify logic for PCI bus ops
......................................................................
Patch Set 2: Code-Review+2
Did no one try to implement mmconf access on an old amd device where the northbridge pci functions couldn't be accessed through mmconf in the southbridge? I would have expected this function to be utilized for such a scenario. But if no one used it then we can reduce the current complexity.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia30d579e1efe6542dc58714f2e7077507847c0de
Gerrit-Change-Number: 31684
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 14:56:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment