Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43508 )
Change subject: libpayload: cbgfx: Add draw_line() ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43508/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43508/1//COMMIT_MSG@15 PS1, Line 15: depending on the value of : pos_rel.y Is there no good way of fixing draw_rounded_box()? I.e. calculating line widths independent of pos_rel.y.
https://review.coreboot.org/c/coreboot/+/43508/1/payloads/libpayload/include... File payloads/libpayload/include/cbgfx.h:
https://review.coreboot.org/c/coreboot/+/43508/1/payloads/libpayload/include... PS1, Line 138: truncated to zero To be strictly precise, maybe "is zero or is truncated to zero"?