Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37607 )
Change subject: superio/common/generic: Assign resources behind device
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37607/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37607/1//COMMIT_MSG@10
PS1, Line 10: need to scan the complete 'bus' even though it is not a bridge.
Commit message still pretends that this is not a bridge.
Ack
https://review.coreboot.org/c/coreboot/+/37607/4/src/superio/common/generic....
File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/37607/4/src/superio/common/generic....
PS4, Line 24: assign_resources(dev->link_list);
Please check for null pointers. Also, this assumes there is only a single […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id80a2ae6e82c151b8d8adc9c5f35f38362d538fa
Gerrit-Change-Number: 37607
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 15:50:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment