Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30834 )
Change subject: Documentation: Add coding style ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md File Documentation/coding_style.md:
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md@1 PS2, Line 1: # Coding Style Is this the coreboot coding style or the Linux coding style? There's several places in which the text refers to Linux, but if we're hosting the coreboot wiki style, we would have to rewrite those parts a bit to refer to our environment. I commented on a few relevant cases (referring to some files)
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md@730 PS2, Line 730: <linux/device.h> Does this apply for us?
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md@733 PS2, Line 733: <linux/printk.h> : I think this is different in our case.
https://review.coreboot.org/#/c/30834/2/Documentation/coding_style.md@840 PS2, Line 840: include/linux/kernel.h This one is different in our case.